Fix SIGINT handling in high-load ephemeral TCP/UDP mode #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Enhanced waitLim() function to be more responsive to context cancellation - Added explicit context checks in ephemeral/UDP connection loops - Replaced Dial with DialContext for context-aware connection establishment - Added connection deadlines based on context for interruptible network operations - Fixed labeled breaks to properly exit loops on cancellation Resolves issue where client processes in high-load ephemeral mode could not receive SIGINT signals due to thousands of goroutines blocking in network I/O. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
…ncellation - Added TestWaitLimContextCancellation to verify improved waitLim responsiveness - Added TestConnectEphemeralContextCancellationLoop to test ephemeral loop cancellation - Added TestConnectUDPContextCancellationLoop to test UDP loop cancellation - Added TestConnectPersistentContextCancellationQuick for persistent connection cancellation - Added TestDialContextWithTimeout to verify DialContext respects context timeouts - Added TestConnectionDeadlineHandling to test connection deadline functionality - Added TestEphemeralLoopBreakOnCancellation to verify labeled break functionality - Added TestUDPLoopBreakOnCancellation to test UDP loop break behavior - Added TestWaitLimRateLimitingBehavior to test rate limiting while maintaining responsiveness Coverage improved from 59.9% to 60.8% of statements. All tests specifically validate the SIGINT handling improvements made to client.go. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
… version `GLIBC_2.34' not found"
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue where client-side processes running in high-load ephemeral TCP or UDP mode cannot receive SIGINT signals for graceful termination.
Dial()calls with context-awareDialContext()Test plan
make test)make build)🤖 Generated with Claude Code